Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FINNA-2739] Unify confirm button styles and remove local adjustments #3083

Merged
merged 17 commits into from
Dec 10, 2024
Merged

[FINNA-2739] Unify confirm button styles and remove local adjustments #3083

merged 17 commits into from
Dec 10, 2024

Conversation

LuomaJuha
Copy link

@LuomaJuha LuomaJuha commented Nov 12, 2024 •
edited
Loading

@LuomaJuha LuomaJuha marked this pull request as draft November 13, 2024 10:35
@LuomaJuha LuomaJuha marked this pull request as ready for review November 18, 2024 09:27
@LuomaJuha LuomaJuha requested a review from EreMaijala December 3, 2024 09:46
EreMaijala
EreMaijala requested changes Dec 9, 2024
View reviewed changes
Copy link

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielä vähän erinäköiset nuo dropdownit (testattu macOS Firefox & Chrome):
kirjastokortti

lista

Sanoisin, että tuossa listan poistossa hover-tausta on paremman näköinen, kun se täyttää suunnilleen tuon alueen.

@LuomaJuha LuomaJuha requested a review from EreMaijala December 9, 2024 12:57
EreMaijala
EreMaijala requested changes Dec 10, 2024
View reviewed changes
Copy link

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Melkein ok, mutta listan poistossa väliviivat ovat jotenkin "järeämmät". Kirjastokortin poisto näyttää nyt paremmalta.

@LuomaJuha LuomaJuha requested a review from EreMaijala December 10, 2024 11:19
@LuomaJuha
Copy link
Author

LuomaJuha commented Dec 10, 2024 •
edited
Loading

Joo, vähä borderit oli nihkeästi noissa.

@EreMaijala EreMaijala merged commit 1c4d746 into NatLibFi:dev Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EreMaijala EreMaijala EreMaijala approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuomaJuha @EreMaijala